PatBK

Maar dat is beter dan niks

classes/Cart.php is anders in 1.6.1.5 en na uitpluizen en aanpassen werkt deze fix niet helaas.

Hallo, herkent iemand dit? Een product kost €25, een optie €5 en prestashop maakt er €30,01 van. Ik heb dit gevonden... http://www.presta-addons.net/gb/content/7-incorrect-tax-rounding-and-application-in-prestashop-161 Maar vind het wel een beetje vreemd dat een derde partij een oplossing heeft en de bug kennelijk niet gerapporteerd en/of opgelost wordt/is in Prestashop zelf. Mis ik iets? Mvgr, Patrick

Hallo, het valt mij op dat wanneer een klant een bestelling doet en extra text bij het product invoert, niet bij de bestelling maar bij het product, dat prima werkt. Wanneer ik hetzelfde doe vanuit de admin pagina, worden er, lijkt het, meer orderregels aangemaakt en wordt de order aangemaakt met het product 2x en dus de prijs ook. Hoe los ik dit op? Mvgr, Patrick

Hi, how do I get this in 1.6.1.5?

The issue was with the order status change settings. When in there, in the status, an order is set paid, a new payment entry is made. The way to fix this is to disable payment set in the order change line. It's the 'zet bestelling op betaling ontvangen' line which needs to be unchecked.

I hope you don't feel I was criticizing you or worse. It was my question and following a suggestion for a fix.

Shouldn't it be something like.... // set orders as paid if ($new_os->paid == 1) { $invoices = $order->getInvoicesCollection(); if ($order->total_paid != 0) { $payment_method = Module::getInstanceByName($order->module); } foreach ($invoices as $invoice) { /** @var OrderInvoice $invoice */ $rest_paid = $invoice->getRestPaid(); if ($rest_paid > 0 && $order->total_paid == 0) { // added && $order->total_paid == 0 so an allready paid order doesn't get 'paid' double or more in the stats and db entries $payment = new OrderPayment(); $payment->order_reference = Tools::substr($order->reference, 0, 9); $payment->id_currency = $order->id_currency; $payment->amount = $rest_paid; if ($order->total_paid != 0) { $payment->payment_method = $payment_method->displayName; } else { $payment->payment_method = null; } // Update total_paid_real value for backward compatibility reasons if ($payment->id_currency == $order->id_currency) { $order->total_paid_real += $payment->amount; } else { $order->total_paid_real += Tools::ps_round(Tools::convertPrice($payment->amount, $payment->id_currency, false), 2); } $order->save(); $payment->conversion_rate = 1; $payment->save(); Db::getInstance()->execute(' INSERT INTO `'._DB_PREFIX_.'order_invoice_payment` (`id_order_invoice`, `id_order_payment`, `id_order`) VALUES('.(int)$invoice->id.', '.(int)$payment->id.', '.(int)$order->id.')'); } } }

This issue happens in 1.6.1.5 too and to me the code fix seems a poor one as it shouldn't disable setting an order paid, it should check if payment was received and only insert in to the DB if payment wasn't received yet. The option to set paid is a way to not have to select paid manually first before setting another status. Or am I mistaken here?