classic [Solved] Child Themes of Classic issues - missing icons and defunct modules

[gorkij]

Hi group brain!

Now, I've been fiddling with making a child theme of "Classic" so that I don't have to modify the parent theme for every update:

 

parent: classic
name: rsl-classic
display-name: RSL Classic mods
version: 1.0.0
assets:
  use_parent_assets: true

(The simplest, as outlined in the docs)

To this I've copied assets/css/custom.css and theme.css
That's all the structure available. 

However, starting a child theme generates a few issues which I can reproduce on a second install: On the left, basic classic theme. On the right: child theme. Also missing the icon for "Online only"?

What am I missing? The child theme is to inherit all of the parent, correct? And that should include icons, right? 

Cache has been cleared, and I'm running a clean browser for testing purposes.

[Solved] Oh, this is a wonderfully weird thing ; I was reflecting on the clutter of files in the themes/classic/assets/css folder - for some untold reason the theme generates these wee images there instead of in the /var/cache folder - where I'd expect them to be. 

And theme.css seems hardcoded to read them from the assets/css folder? Seriously team? Why?

Edited April 27, 2019 by gorkij (see edit history)

[mausbaus]

Hello @gorkij

Having the same problem. How did you managed to have the child theme (in my case is an exact copy of the classic theme) load the icons?

[gorkij77]

Interestingly enough, I had to copy *all* files from the themes/classic/assets/css to the child theme CSS folder. It doesn't seem to inherit properly in this folder. So copying them all fixed it.

[mausbaus]

More than interesting  Since, in my case, was an exact duplicate of the classic theme, the files were there, in themes/classic_new/assets/css. 

But after you said to copy it... I said... hell, it takes 5 seconds to copy and overwrite the files. I did and what do you know, now they show up lol.

Thank you.

[Rom1CH]

Hi @gorkij77

 

It seems I have the same issue as yours. After creating a child theme from an existing parent one, my site has the same issues your sceenshots show.
Can I ask you to explain a bit further what you mean here :

Quote

 

[Solved] Oh, this is a wonderfully weird thing ; I was reflecting on the clutter of files in the themes/classic/assets/css folder - for some untold reason the theme generates these wee images there instead of in the /var/cache folder - where I'd expect them to be. 

And theme.css seems hardcoded to read them from the assets/css folder? Seriously team? Why?

 

I have copied the exact same files in the child from the parent theme -> Perfect mirror. I have activated this theme and I have also checked that the shop1.json file has been created in ROOT/config/themes/THE_CHILD_THEME/shop1.json

Could you please, let me know what you mean by "...for some untold reason the theme generates these wee images there instead of in the /var/cache folder - where I'd expect them to be. " ? What did you do exactly ? As it might be the key to fix this issue, can you let me know your solution ?

Also, I am not sure what you did to fix it : "And theme.css seems hardcoded to read them from the assets/css folder? Seriously team? Why?" ?
Looking at the network tab, my CSS child theme file : /themes/THE_CHILD_THEME/assets/css/theme.css is loaded correctly ?

I add that I had a js issue coming from a script not loaded. The weird thing is that this script was outsite the /themes/ folder (so the called references should not have been modified when duplicating and activating the child theme ?). I managed to fix it adding the js code of this file at the end of the child theme theme.js file.

 

Any tips/advices about it is apreciated !
Thank you very much

[gorkij77]

On 7/18/2019 at 1:38 PM, gorkij77 said:

Interestingly enough, I had to copy *all* files from the themes/classic/assets/css to the child theme CSS folder. It doesn't seem to inherit properly in this folder. So copying them all fixed it.

Hi there @Rom1CH, the above is how I solved it. Mind you, this is quite a few revisions back in the system and some issues might have been adressed since then. But the basic hack was to just copy everything. 

[Rom1CH]

Hello @gorkij77

I almost managed to set up the child theme. I say almost for  2 reasons, first I don't know exactly what I did to get rid of the errors, (some CDN replications maybe), I don't know... I successfully load assets and generate pages from the theme templates (that I can modify) but I can't custom modules from the child theme in order to not lose it at update.

So, what I did, I tried to copy the full folders of modules but it seems that the inheritance of .tpl is not correctly set up when I make a simple change. I activated the debug mode and I can see the original modules path. So I started to hard code paths to the child theme modules folder without success, I still see the original path.

Do you remember having done something more than just copying the full module folder ?

[gorkij77]

Sorry for the tardy reply, but sadly no. I headbutted this issue for three days before this solution fixed it. This is going to sound like me being a total jerk, but have you cleared the cache, both in the back end and purged the old folders? Then tried reloading in a completely wiped browser? 

[Rom1CH]

Hello Gorkij77,

 

No problem for the late answer.

In fact, yes, I cleared cache and deleted cache folders manually. With no success, so I ended up modifying root module folder files and not the ones in my child theme.

If you have a solution or someone has it, let me know !

Thanks