[SOLVED] Commenting out code (<! -- like this -- >) has caused some unusual Firefox problems!

[noesac]

(IGNORE THE SPACING IN MY COMMENT FORMAT, I CHANGED TO TO PREVENT IT FROM MESSING UP THIS POST)

This is my commenting convention:




code that I want to comment out

-- >


I did it on the following two pieces of code:

{l s='View' mod='categoryproductsone'}

{$product.name|truncate:35}

{$product.description_short|truncate:130}

In the code, it appears to be commended out perfectly - it's all grey in Dreamweaver and when I look in Chrome it's fine. However when I look at it in Firefox, the commenting doesn't work:


http://i27.tinypic.com/2zpma7s.jpg

As you can see in the screenshot above, it should look like the picture on the right, but for about 5% of products the commenting doesn't seem to be applied!!

This is so weird. And made even weirder by the fact that it only affects about 5% of products, and only in Firefox.


Anyway this was a very easy fix for me - I just deleted all the code instead of commenting it out.

However my concern is that I've used a similar commenting format elsewhere, am I going to find other problems?

[noesac]

I just made this same mistake again.

I tried all browsers - IE, Firefox, Chrome, Safari (Win and Mac) and it still seems to affect Firefox only.

Should I raise this bug in the bug tracker? Or has it already been fixed in 1.3.1 (I'm still on 1.2.5).

[rocky]

I think it is a browser bug rather than a PrestaShop bug, so there is no point in reporting it on the bug tracker. You should be Smarty comments {* *} instead of HTML comments anyway. That way, the code isn't downloaded at all instead of downloaded and just ignored. I've had problems with the HTML comment tags before. I found that rather than putting the whole comment on one line, you should put the opening tag, comment and closing tags on separate lines.

[noesac]

Great thanks Rocky, I will switch over to that style of commenting when I upgrade to v1.3.1

[aimrob]

Rocky,

I am new to Prestashop, and to altering code, so please forgive me if (or when) I don't word this correctly. :-)

I would like to remove these functions as well. Would you mind giving me the codes to comment out for version 1.3.6.0?

I tried it and my shopping cart showed "page not found" so I changed it back.

Also, when "commenting" something out, does this mean I should add a {* before the code in the pink box, and then a *} at the end of the code?

Thanks very much!

Amy