bug in resetAddressCache - address related issue

[fransjaeger]

 

Hi

I think I have found a bug, that might have annoyed many people with diverse error messages on adding address via OPC ajax

 

Please look at the below and notice how its not using the same key value

 

	public static function customerHasAddress($id_customer, $id_address)
	{
		$key = (int)$id_customer.'-'.(int)$id_address;
		if (!array_key_exists($key, self::$_customerHasAddress))
		{
			self::$_customerHasAddress[$key] = (bool)Db::getInstance(_PS_USE_SQL_SLAVE_)->getValue('
			SELECT `id_address`
			FROM `'._DB_PREFIX_.'address`
			WHERE `id_customer` = '.(int)$id_customer.'
			AND `id_address` = '.(int)$id_address.'
			AND `deleted` = 0');
		}
		return self::$_customerHasAddress[$key];
	}

	public static function resetAddressCache($id_customer)
	{
		if (array_key_exists($id_customer, self::$_customerHasAddress))
			unset(self::$_customerHasAddress[$id_customer]);
	}

$_customerHasAddress[$id_customer]

vs

$_customerHasAddress[$key] (which is actually $id_customer.'-'.$id_address;)

 

 

Here is my workaround (it might not be perfect(fast enough), but it works)

    public static function resetAddressCache($id_customer)
    {
        // lets reset (could be improved by loopin and removing all keys beginning with $id_customer.'-')
        self::$_customerHasAddress = array();
    }

Here is my newest and best attempt
 

    public static function resetAddressCache($id_customer)
    {
        foreach (self::$_customerHasAddress as $key => $value) {
            list($firstPart) = explode('-', $key);
            if ((int)$firstPart == $id_customer)
                unset(self::$_customerHasAddress[$key]);
        }
    }

Hope it helps
and please post if you have a better fix

Edited February 7, 2015 by michaelhjulskov (see edit history)

[fransjaeger]

If you like this, please create a link that points to www.dyrefoder.dk THANKS ;o)

Edited February 7, 2015 by michaelhjulskov (see edit history)

[fransjaeger]

I made a pull request here

https://github.com/PrestaShop/PrestaShop/pull/2466