FluffyCat Posted July 7, 2013 Share Posted July 7, 2013 Hi I have a website in 2 languages. Previously I have used the sitemap module and it generates one index file and 2 other sitemaps, one for each language. Today I updated the Sitemap module. It says it completes ok but the index file is not created. It appears as the other 2 files are generated but the link to the index file from the backoffice leads to a 404 and I checked the ftp as well. The 1_en_0_sitemap.xml and 1_es_0_sitemap.xml are there but not the index file that the previous version generated. Anyone had similar issues? Link to comment Share on other sites More sharing options...
fida Posted July 8, 2013 Share Posted July 8, 2013 Hi I have a website in 2 languages. Previously I have used the sitemap module and it generates one index file and 2 other sitemaps, one for each language. Today I updated the Sitemap module. It says it completes ok but the index file is not created. It appears as the other 2 files are generated but the link to the index file from the backoffice leads to a 404 and I checked the ftp as well. The 1_en_0_sitemap.xml and 1_es_0_sitemap.xml are there but not the index file that the previous version generated. Anyone had similar issues? I am from Italy and I have this problem: The new Google sitemap has generate the file: 1_it_0_sitemap.xml but it not work because when I update it on google it give only errors and tell me: TAG XML IS MISSING Link to comment Share on other sites More sharing options...
FluffyCat Posted July 10, 2013 Author Share Posted July 10, 2013 I got errors as well when uploading to Google. Finally I have reverted to an older version of gsitemap and it appears to work and google accepts the xml files just fine. The 2.3.3 version is not ok, at least not for us. Link to comment Share on other sites More sharing options...
Floobynooby Posted July 19, 2013 Share Posted July 19, 2013 Can you advise which older version you used that worked as im having the same problem? Link to comment Share on other sites More sharing options...
sadlyblue Posted July 19, 2013 Share Posted July 19, 2013 I'm still using 1.9. Not perfect, but works better than any 2.* Sometimes i think if it wasn't on purpose, so someone can sell a good sitemap module. I mean, why take so long to fix something that looks simple, take the urls and output to a file... I haven't built one myself because i'm busy with another project. Link to comment Share on other sites More sharing options...
FluffyCat Posted July 19, 2013 Author Share Posted July 19, 2013 I moved back to 2.1.1 which came with the original upgrade to 1.5.4.1 that I did and this version seems to work ok. Link to comment Share on other sites More sharing options...
Floobynooby Posted July 19, 2013 Share Posted July 19, 2013 Will Give it a try thanks. Link to comment Share on other sites More sharing options...
fandain Posted July 25, 2013 Share Posted July 25, 2013 Hi I just uninstalled it , reinstall, reset and configure. Problem gone. Cheers Link to comment Share on other sites More sharing options...
benjamin utterback Posted July 25, 2013 Share Posted July 25, 2013 I moved back to 2.1.1 which came with the original upgrade to 1.5.4.1 that I did and this version seems to work ok. Will Give it a try thanks. I am from Italy and I have this problem: The new Google sitemap has generate the file: 1_it_0_sitemap.xml but it not work because when I update it on google it give only errors and tell me: TAG XML IS MISSING I'm still using 1.9. Not perfect, but works better than any 2.* Sometimes i think if it wasn't on purpose, so someone can sell a good sitemap module. I mean, why take so long to fix something that looks simple, take the urls and output to a file... I haven't built one myself because i'm busy with another project. Hello everybody, if you could please use the updated GoogleSiteMap module 2.2.6 attached in this post, compatible with v 1.5 Make sure confirm a working backup of your Database and PrestaShop files before changing any module. Keep me post and thank you! gsitemap.zip 3 Link to comment Share on other sites More sharing options...
sadlyblue Posted July 26, 2013 Share Posted July 26, 2013 I don't think it's working. The problem is still with multishop, at least. First i select only one shop, and in the sitemap was a mix of all shops. Second, in a product had a link for site A, but the image link was from site B. Last, it did not "built" the main index for each page. We have almost 2500 product, on a dedicated server, timeout more than 10 minutes for php, and memory limits, and it still "times out". If i click again, it will start from scratch. Link to comment Share on other sites More sharing options...
benjamin utterback Posted July 26, 2013 Share Posted July 26, 2013 Hi sadlyblue, thank you for the feedback. If you could, please PM me your link to your sitemap. We will take a look at it. Link to comment Share on other sites More sharing options...
Frank1957 Posted July 28, 2013 Share Posted July 28, 2013 I am not using friendly URL's and the latest and the latest version looks like it is creating a sitemap with friendly URL's. Link to comment Share on other sites More sharing options...
ectrading Posted July 29, 2013 Share Posted July 29, 2013 Hi, I am having the same problems, I am not using friendly URLs but the sitemap is generating freindly URLS! Please help Link to comment Share on other sites More sharing options...
benjamin utterback Posted July 29, 2013 Share Posted July 29, 2013 Hi, I am having the same problems, I am not using friendly URLs but the sitemap is generating freindly URLS! Please help Hi ectrading, are you using the latest gsitemap module? 1 Link to comment Share on other sites More sharing options...
ectrading Posted July 29, 2013 Share Posted July 29, 2013 Hi Ben, I am using the latest version, I have now disabled it. Happy to give you FTP access and BO access if that helps? Link to comment Share on other sites More sharing options...
benjamin utterback Posted July 29, 2013 Share Posted July 29, 2013 I don't think it's working. The problem is still with multishop, at least. First i select only one shop, and in the sitemap was a mix of all shops. Second, in a product had a link for site A, but the image link was from site B. Last, it did not "built" the main index for each page. We have almost 2500 product, on a dedicated server, timeout more than 10 minutes for php, and memory limits, and it still "times out". If i click again, it will start from scratch. Hi sadlyblue, you are right. In multi-shop the images are not being called from the right URL. We are fixing this feature for the next small update and we will update you as soon as be publish it. Thank you! Link to comment Share on other sites More sharing options...
benjamin utterback Posted July 29, 2013 Share Posted July 29, 2013 Hi Ben, I am using the latest version, I have now disabled it. Happy to give you FTP access and BO access if that helps? Hi if you are using the latest version, it should be not displaying Friendly URL unless you are using it. Have you re-indexed your sitemap in the configuration of the module? Link to comment Share on other sites More sharing options...
Frank1957 Posted July 30, 2013 Share Posted July 30, 2013 I have regenerated the site map using version 2.2.6 and I still have the problem of an incorrect URL(I think friendly URL is being generated). If I turn friendly URL's on to fix the site map problem the cart stops working with a 404 error. Link to comment Share on other sites More sharing options...
juanmlg Posted August 6, 2013 Share Posted August 6, 2013 Hello everybody, if you could please use the updated GoogleSiteMap module 2.2.6 attached in this post, compatible with v 1.5 Make sure confirm a working backup of your Database and PrestaShop files before changing any module. Keep me post and thank you! Works! Link to comment Share on other sites More sharing options...
robbie007 Posted August 24, 2013 Share Posted August 24, 2013 I don't think it's working. The problem is still with multishop, at least. First i select only one shop, and in the sitemap was a mix of all shops. Second, in a product had a link for site A, but the image link was from site B. Last, it did not "built" the main index for each page. We have almost 2500 product, on a dedicated server, timeout more than 10 minutes for php, and memory limits, and it still "times out". If i click again, it will start from scratch. Have the same problem in multistore. It takes some url's of other shops. Get notifications of Google Webmaster tools with 404's. Can't be good. Think I have to turn Google Sitemap off till it's solved. Even after latest update 2.2.7. Link to comment Share on other sites More sharing options...
robbie007 Posted August 24, 2013 Share Posted August 24, 2013 And all priorities are at 0.1. What kind of sitemap is this??? This is not the quality we are looking for. Link to comment Share on other sites More sharing options...
sadlyblue Posted August 24, 2013 Share Posted August 24, 2013 I just don't understand why is taking so long to fix these problems... Link to comment Share on other sites More sharing options...
robbie007 Posted August 28, 2013 Share Posted August 28, 2013 Benjamin Utterback, when can we expect update 2.2.8 wich finally helpes us out?? Link to comment Share on other sites More sharing options...
benjamin utterback Posted August 28, 2013 Share Posted August 28, 2013 I just don't understand why is taking so long to fix these problems... Benjamin Utterback, when can we expect update 2.2.8 wich finally helpes us out?? Hi sadlyblue and robbie007, Do you think you could PM me your FTP information, along with your Contact info, and BO Log in and Password. However, first, Be sure to confirm a working backup of both your mySQL database and PrestaShop files through FTP... We will take a look at the issue. Both of you are using Multi-store right? Link to comment Share on other sites More sharing options...
Frank1957 Posted September 2, 2013 Share Posted September 2, 2013 Has the site map been fixed. I still have a problem with incorrect url's being created. Link to comment Share on other sites More sharing options...
Frank1957 Posted September 2, 2013 Share Posted September 2, 2013 Has the site map been fixed. I am still having a problem. I am not a multi store site. Link to comment Share on other sites More sharing options...
sadlyblue Posted September 4, 2013 Share Posted September 4, 2013 Hi sadlyblue and robbie007, Do you think you could PM me your FTP information, along with your Contact info, and BO Log in and Password. However, first, Be sure to confirm a working backup of both your mySQL database and PrestaShop files through FTP... We will take a look at the issue. Both of you are using Multi-store right? Since this is not my own store, but owned by the company i work for, you understand why i can't give you those accesses. But, if there are any tests, or ideas on how to solve, i can help with that and test them. First i wonder if you have already tested on a new multishop install with a couple of products and a couple of languages and stores. If it works fine there it should work well with our sites. Link to comment Share on other sites More sharing options...
robbie007 Posted September 4, 2013 Share Posted September 4, 2013 Well, that was exactly the same I was thinking about. It's easy to test by Presta. I don't feel the problem has to do with one specific site. Link to comment Share on other sites More sharing options...
rakepl Posted September 6, 2013 Share Posted September 6, 2013 (edited) Hello Benjamin ! Where is google sitemap in Prestashop/modules, I can't find it ? Can you post newest gsitemap module for Prestashop here ? will be work with Prestashop 1.4.10 ? Thank you PS, I tried to install this 2.2.6 version d/l from this post on PS 14.10 but it makes bank when click configure in BO/modules/seo/Google sitemap v2.2.6 by PrestaShop/configure Edited September 6, 2013 by rakepl (see edit history) Link to comment Share on other sites More sharing options...
bannerclick Posted September 10, 2013 Share Posted September 10, 2013 Stil issues... Did anyone manage to build a correct sitemap with multistore?? Link to comment Share on other sites More sharing options...
bannerclick Posted September 11, 2013 Share Posted September 11, 2013 Anyone an idea? I have tried to generate sitemap on localhost, and see a wrong URL for the second shop; the directory contains a duplicate: http://localhost:8888/prestest/prestest/2_index_sitemap.xml This probably is where things go wrong? Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 11, 2013 Share Posted September 11, 2013 Hello everybody, We are working on this issue with Google Sitemap and Multistore. If you are having this issue and you are using Multistore, feel free to create a backup of your database and PrestaShop files, and PM me your FTP information with back Office credentials. Our Dev team will take a look at your store. I will keep you updated on the release date of the new module. Thank you! Link to comment Share on other sites More sharing options...
robbie007 Posted September 11, 2013 Share Posted September 11, 2013 I already provided you access. All for the community :-) It's a very important issue (to let search engines better understand your presta stores), so please help them too guys. Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 11, 2013 Share Posted September 11, 2013 I already provided you access. All for the community :-) It's a very important issue (to let search engines better understand your presta stores), so please help them too guys. Thanks Robert, We did get your FTP and we will taking a look at it tomorrow. Thank you for the update! Link to comment Share on other sites More sharing options...
bannerclick Posted September 12, 2013 Share Posted September 12, 2013 My problem looks solved with the latest version on Github (2.2.8.) Thanx!! Link to comment Share on other sites More sharing options...
bannerclick Posted September 12, 2013 Share Posted September 12, 2013 (edited) hmm, was a bit too early...Google says parse error now And all generated sitemaps contain errors, not just the second store... Edited September 12, 2013 by bannerclick (see edit history) Link to comment Share on other sites More sharing options...
bannerclick Posted September 16, 2013 Share Posted September 16, 2013 How hard can this be??? Just test a new version before you put it on github...Come on guys, setup a teststore with multistore and multislanguage and see what happens. Anyone with alternatives?? Link to comment Share on other sites More sharing options...
sadlyblue Posted September 16, 2013 Share Posted September 16, 2013 Anyone with alternatives?? I'm thinking about developing an alternative for our store. We don't want to display our suppliers, we still use the old system for images,... and other options. I don't think i'll even bother (and waste time) creating the options for those things, since we don't need them. Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 16, 2013 Share Posted September 16, 2013 Hello all, just to update you all, we are still testing the sitemap module and troubleshooting the issues with multistore. I thank you for your understanding and patience as we continue to test and fix this aspect of the module. My apologizes for the delay. Link to comment Share on other sites More sharing options...
Dolke Posted September 18, 2013 Share Posted September 18, 2013 (edited) Hi to all, I just created sitemap with a default module (2.2.8 version from the gitHub) but I needed my hosting provider to increase the value of max execution time to 120 sec. Just saying if someone is having problems with timeouts...How do you know when sitemap have issues with bad URLs?This is mine and it does show some error on the top of the file >>> http://dekom.co.rs/1_sr_0_sitemap.xmlIs that it?P.S. Can someone explain me this what is option: "Check this box if you wish to check the presence of the image files on the serve" actually do? Thanks.Dean Edited September 18, 2013 by Dolke (see edit history) Link to comment Share on other sites More sharing options...
Dolke Posted September 18, 2013 Share Posted September 18, 2013 Just to report that Google just refused my sitemap.It reported error in parsing.I will try using 2.2.7 or 2.2.6 version untill Benjamin post that they have fixed this module. Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 18, 2013 Share Posted September 18, 2013 Just to report that Google just refused my sitemap. It reported error in parsing. I will try using 2.2.7 or 2.2.6 version untill Benjamin post that they have fixed this module. Hi Dolke, if you are using multistore then I'm not sure if it would work for you. Please keep us updated on the status. We know what the problem is and we are working hard to fix it asap. It certainly is taking longer than expected and we appreciate everybody's patience as we solve the problem. Thank you! Link to comment Share on other sites More sharing options...
Dolke Posted September 18, 2013 Share Posted September 18, 2013 Hi Benjamin, Check everything that I posted, all options. I don't use multistore but still Google reported problem with all 3 sitemaps generate respectively with 2.2.8, 2.2.7 and 2.2.6 version of the module.Hope issue will be fixed soon. Thanks Link to comment Share on other sites More sharing options...
Dolke Posted September 19, 2013 Share Posted September 19, 2013 While we all wait can somebody give me a link to download version 2.1.1 that came original with 1.5.4.1 Prestashop?I would like to try it with my website. Thank you. Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 19, 2013 Share Posted September 19, 2013 I already provided you access. All for the community :-) It's a very important issue (to let search engines better understand your presta stores), so please help them too guys. Hi Robert, good news. It seems that we fixed the issue on your store. We fixed it by deleting one line of code in the classes/dispatcher.php You can take a look at the change here, https://github.com/PrestaShop/PrestaShop/commit/3607c2264fb7ba9a3dae0e173098ecc0f6b16488 I suggest others to see if this change is reflected as well. Link to comment Share on other sites More sharing options...
robbie007 Posted September 19, 2013 Share Posted September 19, 2013 Hi Benjamin, Good job!! Will have a look and finally can add some good sitemaps for Google. Cheers, Robert Link to comment Share on other sites More sharing options...
bannerclick Posted September 19, 2013 Share Posted September 19, 2013 Benjamin, I can't find this line of code in presta 1.5.5, so deleting will be a bit hard. Maybe we have to look for the older despatcher.php and see what happens?? Anyway, i was hoping for a real solution by now....Is a new setup of v. 1.5.5 and multistore/multilanguage not giving any problems? Link to comment Share on other sites More sharing options...
Dolke Posted September 19, 2013 Share Posted September 19, 2013 Hi, In Prestashop 1.5.4.1 this line is 209 in the classes/dispatcher.php I made new sitemap and submitted it to Google. Well see what happens now. Thank you Benjamin, I really hope this works.Cheers Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 19, 2013 Share Posted September 19, 2013 Hi, In Prestashop 1.5.4.1 this line is 209 in the classes/dispatcher.php I made new sitemap and submitted it to Google. Well see what happens now. Thank you Benjamin, I really hope this works. Cheers Keep me posted my friend. We will work to fix any remaining issues that may occur. Link to comment Share on other sites More sharing options...
bannerclick Posted September 19, 2013 Share Posted September 19, 2013 Ok, the latest version (2.2.9) seems to solve some issues; the XML is valid at least. For me, the URL's from my second store are not friendly, and result all in a 404 error. So the remaining issue (the one i started with) is my url in the sitemap looks like this: my-url/nl/index.php?controller=product_rule&id=1001&rewrite=overhemd-wit-51001&ean13=&meta_keywords=maathemdoverhemdoverhemd-op-maatoverhemduniwitkatoen&meta_title= where i expect (generated correct in the first shop): my-url/nl/overhemd-op-maat/1001-overhemd-blauw-51001.html Link to comment Share on other sites More sharing options...
Dolke Posted September 19, 2013 Share Posted September 19, 2013 (edited) Keep me posted my friend. We will work to fix any remaining issues that may occur. Will do, np Ok, the latest version (2.2.9) seems to solve some issues I'm sorry but where did you get version 2.2.9? As I recall latest version is 2.2.8 Edited September 19, 2013 by Dolke (see edit history) Link to comment Share on other sites More sharing options...
bannerclick Posted September 19, 2013 Share Posted September 19, 2013 2.2.9 was just posted on github Link to comment Share on other sites More sharing options...
Dolke Posted September 20, 2013 Share Posted September 20, 2013 Im not sure that I follow. Where is the link to 2.2.9 version. All I see here is that we need to delete one line in classes/dispatcher.php but I dont see new module. I was using 2.2.8 module with this line deleted from the file. Google reported me the same parsing error. Link to comment Share on other sites More sharing options...
bannerclick Posted September 20, 2013 Share Posted September 20, 2013 here is the new version: https://github.com/PrestaShop/PrestaShop-modules/tree/master/gsitemap with a bit of luck, your problem is solved... Link to comment Share on other sites More sharing options...
Dolke Posted September 20, 2013 Share Posted September 20, 2013 I'm pretty new with the gitHub. I you gave me link to actual project files and tools. Where can I download the new version? Link to comment Share on other sites More sharing options...
mark-b Posted September 20, 2013 Share Posted September 20, 2013 Hi All, It looks like it works now, I only hope with removing "$this->use_routes = false;" in the dispatcher does not mess up some rooting or url mismatch somewhere else... Link to comment Share on other sites More sharing options...
bannerclick Posted September 20, 2013 Share Posted September 20, 2013 cant really download the new version, just overwrite sitemap.php with the one you can find here. If you choose raw, you can select the new code and overwrite the existing code. It worked for me.. Link to comment Share on other sites More sharing options...
mark-b Posted September 20, 2013 Share Posted September 20, 2013 here is the updated gsitemap file gsitemap.zip Link to comment Share on other sites More sharing options...
Dolke Posted September 20, 2013 Share Posted September 20, 2013 (edited) @bannerclickThanks for clarifying that for me.@mark-bThanks for the new file Mark. I just wonder now with 2.2.9 version do I still need to delete line 209 in dispacher.php file or try without deleting? Benjamin proposed that as solution for a specific website and not general solution. Thanks. Edited September 20, 2013 by Dolke (see edit history) Link to comment Share on other sites More sharing options...
bannerclick Posted September 20, 2013 Share Posted September 20, 2013 try withouth deleting first, and see what happens. If its still not ok, try deleting the line, and check again Link to comment Share on other sites More sharing options...
Dolke Posted September 20, 2013 Share Posted September 20, 2013 OK done that.Now we waits and see what happens. Thanks Link to comment Share on other sites More sharing options...
mark-b Posted September 20, 2013 Share Posted September 20, 2013 hi, to get it work correctly, you must remove line 209 from the dispatcher Link to comment Share on other sites More sharing options...
Dolke Posted September 20, 2013 Share Posted September 20, 2013 It seems so. Im confirming this last post from mark-b. thanks Link to comment Share on other sites More sharing options...
Dolke Posted September 20, 2013 Share Posted September 20, 2013 Unfortunately this doesn't work for me. Here is the screenshot from the webmaster tools and error that I'm receiving. http://www.screencast.com/t/NsRdX9kMdoG Any suggestion? Mr Benjamin? Link to comment Share on other sites More sharing options...
ectrading Posted September 20, 2013 Share Posted September 20, 2013 Hi, I have updated with the latest version of gsitemap.php but I am still getting friendly URL's when I am not using them. Any ideas? Link to comment Share on other sites More sharing options...
mark-b Posted September 20, 2013 Share Posted September 20, 2013 To Dolke: Your site map looks fine to me, what language is it? Link to comment Share on other sites More sharing options...
mark-b Posted September 20, 2013 Share Posted September 20, 2013 If you have an custom url configuration (like: www.domain.com/12-product.html) you should edit the dispatcher, you you use the standard prestashop url configuration, you should not edit the dispatcher.. Link to comment Share on other sites More sharing options...
Dolke Posted September 20, 2013 Share Posted September 20, 2013 @Mark-bIts Serbian language. Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 20, 2013 Share Posted September 20, 2013 Unfortunately this doesn't work for me. Here is the screenshot from the webmaster tools and error that I'm receiving. http://www.screencast.com/t/NsRdX9kMdoG Any suggestion? Mr Benjamin? Hello, have you edited the path to your URLs in the dispatcher? Hi, I have updated with the latest version of gsitemap.php but I am still getting friendly URL's when I am not using them. Any ideas? Could you make sure to have a backup and delete your htaccess manually in the backoffice and regenerate. Link to comment Share on other sites More sharing options...
Dolke Posted September 20, 2013 Share Posted September 20, 2013 @BenjaminI'm not sure I did. What exactly do I need to do? Link to comment Share on other sites More sharing options...
Dolke Posted September 23, 2013 Share Posted September 23, 2013 (edited) It seems like sitemap is working now. Google reported me that there is no errors with the sitemap this time and indexed almost all the pages. What about others?Did you manage to make it work? Edited September 23, 2013 by Dolke (see edit history) Link to comment Share on other sites More sharing options...
mark-b Posted September 23, 2013 Share Posted September 23, 2013 It is working for me now, this is the first sitemap of version prestashop 1.5 that is working.... Link to comment Share on other sites More sharing options...
NemoPS Posted September 23, 2013 Share Posted September 23, 2013 I get an unknown column error on a fresh 1.5.5 It's not adding a manufacturer shop table join, but then it's calling it as condition at line 394. I guess it's enough to remove the condition or join entirely Link to comment Share on other sites More sharing options...
Dolke Posted September 23, 2013 Share Posted September 23, 2013 Although I don't see any errors in my webmaster dashboard I'm still not sure is this sitemap performing alright or now. For example many images are not indexed and there a re certain pages that are in the sitemap but not crawled. What do you think guys? Take a look at : http://www.screencast.com/t/bOPcx2yN@Nemo1I guess that one of the temporary solution... so basically you don't check problematic tables right? Link to comment Share on other sites More sharing options...
NemoPS Posted September 23, 2013 Share Posted September 23, 2013 This is the script I mentioned: $manufacturers_id = Db::getInstance()->ExecuteS('SELECT m.`id_manufacturer` FROM `'._DB_PREFIX_.'manufacturer` m INNER JOIN `'._DB_PREFIX_.'manufacturer_lang` ml on m.`id_manufacturer` = ml.`id_manufacturer`'.($this->tableColumnExists(_DB_PREFIX_.'manufacturer_shop') ? ' INNER JOIN `'._DB_PREFIX_.'manufacturer_shop` ms ON m.`id_manufacturer` = ms.`id_manufacturer` ' : '').' WHERE m.`active` = 1 AND m.`id_manufacturer` > '.(int)$id_manufacturer.($this->tableColumnExists(_DB_PREFIX_.'manufacturer_shop') ? ' AND ms.`id_shop` = '.(int)$this->context->shop->id : '').' AND ml.`id_lang` = '.(int)$lang['id_lang'].' ORDER BY m.`id_manufacturer` ASC'); As you can see if that table doesn't exist, it's not joined... but the where statement is there anyway. So, yes, it can be edited as a temporary solution Link to comment Share on other sites More sharing options...
Dolke Posted September 23, 2013 Share Posted September 23, 2013 Nemo1, do you get that msg in the back office once you run sitemap creation? Link to comment Share on other sites More sharing options...
NemoPS Posted September 23, 2013 Share Posted September 23, 2013 which message? I get this:http://awesomescreenshot.com/0421qsc894 Link to comment Share on other sites More sharing options...
Dolke Posted September 23, 2013 Share Posted September 23, 2013 Nevermind, I was thinking something else Im not a developer, well at least not yet, and Im not familiar with the code so Im not sure what are you getting there or what you have found But if I got it, in PS 1.5.5, and you are using vanilla version right, some exception is thrown if the table is not present in the DB when creating a sitemap because there is a condition they all should be joined right? So if there is no condition there is no error right? Why should be such a condition anyway? I guess some Google rules or not? Link to comment Share on other sites More sharing options...
NemoPS Posted September 23, 2013 Share Posted September 23, 2013 ...errr I am not sure about what you're asking me. Vanillawhat? Link to comment Share on other sites More sharing options...
Dolke Posted September 23, 2013 Share Posted September 23, 2013 hahah Well I noticed that some users here on the Forums are using term "Vanilla" for a prestashop fresh install. So basically vanilla would be fresh install of any Prestashop version free of any modification and data, only samples. Link to comment Share on other sites More sharing options...
NemoPS Posted September 23, 2013 Share Posted September 23, 2013 Aww! Never noticed! Yeah it's a fresh install, the module is simply broken on its latest version Link to comment Share on other sites More sharing options...
Dolke Posted September 23, 2013 Share Posted September 23, 2013 You mean broken for 1.5.5 PS version?Well it seems like this module was broken for 1.5.4.1 version as well but these few last changes made it work. Im not sure why Prestashop officials are not taking more attention to this issue? I really wonder what could be more important than fixing module which is so important? Link to comment Share on other sites More sharing options...
NemoPS Posted September 23, 2013 Share Posted September 23, 2013 Well, it's hard to tell whose the fault is I think the module is missing that table condition, so the module is ....more broken in this case! Link to comment Share on other sites More sharing options...
Dolke Posted September 23, 2013 Share Posted September 23, 2013 Well module is Prestashop native right? Link to comment Share on other sites More sharing options...
NemoPS Posted September 23, 2013 Share Posted September 23, 2013 Yes, but versions are separate Link to comment Share on other sites More sharing options...
Dolke Posted September 23, 2013 Share Posted September 23, 2013 (edited) Well neither version of the module was working on neither PS.Only these last few tweaking did something but I always states that those are not real solutions.As end user, I don't want to touch my dispacher.php to fix my sitemap module, no.I would like it to work, that just the fact.You can now tell me its open source and so on, sure it is, but does open source means that essential parts not working, I guess not.But I don't want to complain... instead want to help, be involved as much as I can and make PS the best ecommerce solution. Edited September 23, 2013 by Dolke (see edit history) Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 23, 2013 Share Posted September 23, 2013 Well neither version of the module was working on neither PS. Only these last few tweaking did something but I always states that those are not real solutions. As end user, I don't want to touch my dispacher.php to fix my sitemap module, no. I would like it to work, that just the fact. You can now tell me its open source and so on, sure it is, but does open source means that essential parts not working, I guess not. But I don't want to complain... instead want to help, be involved as much as I can and make PS the best ecommerce solution. Thank you for your support. Have you tried the latest gsitemap from Github? The fixes have worked for many users and I would love to know if it works for you. You can download the zip from here, https://github.com/PrestaShop/PrestaShop-modules (The button to download is on the right) Extract, and upload the new gsitemap module. Let me know if it works for you. Thank you. Link to comment Share on other sites More sharing options...
bannerclick Posted September 23, 2013 Share Posted September 23, 2013 Same problem for me... Friendly URL for the second shop is not correct in the sitemap, but as index.php?controller=product_rule&id=1002&rewrite=overhemd-blauw-51002&ean13=&meta_keywords=maathemdoverhemdoverhemd-op-maatoverhemduniblauwkatoen&meta_title= which results in 404.... Link to comment Share on other sites More sharing options...
Dolke Posted September 23, 2013 Share Posted September 23, 2013 Thank you for your support. Have you tried the latest gsitemap from Github? The fixes have worked for many users and I would love to know if it works for you. You can download the zip from here, https://github.com/PrestaShop/PrestaShop-modules (The button to download is on the right) Extract, and upload the new gsitemap module. Let me know if it works for you. Thank you. Dear Benjamin, I guess I still need that line 209 deleted from the dispatcher.php in order to use this Github version right? Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 23, 2013 Share Posted September 23, 2013 Yes for sure, if you are using multistore then that is necessary. It will be implemented in the next version but it is a good idea to fix that as well. Link to comment Share on other sites More sharing options...
Dolke Posted September 23, 2013 Share Posted September 23, 2013 I'm not using multistore but I deleted that line anyway.I just wonder if this can cause some other controllers or modules not to work properly thats all. Thanks. Link to comment Share on other sites More sharing options...
bannerclick Posted September 23, 2013 Share Posted September 23, 2013 Hi Benjamin, Cant delete that line in 1.5.5 Any suggestions what to do? Does it work in a clean multistore 1.5.5 now? Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 23, 2013 Share Posted September 23, 2013 This is the updated gsitemap attached. Please make sure to always have a backup of your store before you add or edit any module. It's good practice. Please let me know if it works for you. Thanks! gsitemap.zip Link to comment Share on other sites More sharing options...
bannerclick Posted September 23, 2013 Share Posted September 23, 2013 Hi Benjamin, This does exactly the same, for the second store (both languages) the URL is wrong (as written earlier) Link to comment Share on other sites More sharing options...
benjamin utterback Posted September 23, 2013 Share Posted September 23, 2013 Hi Benjamin, This does exactly the same, for the second store (both languages) the URL is wrong (as written earlier) Hi bannerclick, when you are creating the sitemap for your stores, please do not use "All stores" . Can you configure each store separately and let me know if that works? Link to comment Share on other sites More sharing options...
bannerclick Posted September 24, 2013 Share Posted September 24, 2013 Hi Benjamin, I was doing it already like that... Any more suggestions? Thanks Link to comment Share on other sites More sharing options...
mark-b Posted September 24, 2013 Share Posted September 24, 2013 When I install version of Benjamin I get the error: Unknown column 'ms.id_shop' in 'where clause' Link to comment Share on other sites More sharing options...
bannerclick Posted September 24, 2013 Share Posted September 24, 2013 Same for me on the localhost version, but it was ok online.... Link to comment Share on other sites More sharing options...
NemoPS Posted September 24, 2013 Share Posted September 24, 2013 That's a bug, I get the same on a fresh 1.5.5 install. If the manufacturer shop table doesn't exist, it refers to an unknown column as the condition in the where clause is still there. You can try my previous suggestion as a temporary solution! Link to comment Share on other sites More sharing options...
Dolke Posted September 24, 2013 Share Posted September 24, 2013 (edited) Can we all conclude something from this last few posts so new users can find the answer they are looking for?OK so here is the current situation:* Original native Prestashop (both 1.5.4.X and 1.5.5.X) Google sitemap module is not working properly.* Problems seem to appear on multishops as well on singleshop websites. * There has been efforts from the community to solve these issues, there for new version of the module has been lunched.* Download link for the new version is in the Mr. Benjamin s post no. 93 at the bottom.* This new version is requiring line 209 from the dispacther.php file (located in the classes/dispatcher.php) to be deleted.* This fix so far is applied only for prestashop version 1.5.4.X while others using 1.5.5.X still experience issues which were explained by Mr. Nemo1 i the posts 73,75 and 77 of this topic.In conclusion we are still waiting for a real-deal solution from the Prestashop developers. This real-deal solution would be simple, fully-functional, universal (not depending on a version of Prestashop) module for generating clean Google sitemaps. That way well be affecting our SEO in a positive way and send clear msg that Prestashop is no. open source e-commerce platform.Cheers Edited September 24, 2013 by Dolke (see edit history) 1 Link to comment Share on other sites More sharing options...
Recommended Posts