Why doesn't Maintenance IP work anymore in presta 1.4.4.0?

[Billy]

I have a fresh install of presta 1.4.4.0 and the Maintenance IP mode no longer works? I enable it just like I always have.

 

I go to http://www.whatismyip.com/ and get my ip address then add it to BO but it doesn't work anymore. All I can see is the...

 

In order to perform site maintenance, our online shop has shut down temporarily. We apologize for the inconvenience and ask that you please try again later.

 

What happened???

[Richard S]

Everything works to me.

 

You do not need to go to other sites in order to add IP. You can use the button Add my IP.

[Billy]

Everything works to me.

 

You do not need to go to other sites in order to add IP. You can use the button Add my IP.

 

When I hit the (Add my IP) button it adds the server IP not my IP? Something is not right...

 

 

Server information

----

Prestashop Version: 1.4.4.0

Server information: Linux #1 SMP Thu Nov 18 16:04:02 MSK 2010 i686

Server software Version: Apache

PHP Version: 5.3.6

MySQL Version: 5.1.56-log

[Billy]

This affects all versions of prestashop on my server. I have 4 sites running prestashop in different versions.

 

1 site 1.3.1.1

2 sites 1.4.3.0

1 site 1.4.4.0

 

The feature use to work on an older version of php. However it does not work with my current version of php 5.3.6 server wide.

 

I have also tested it in two browsers so far.

 

IE8

FF 5.0

 

Bug report has been filed

http://forge.prestashop.com/browse/PSCFI-3027

[Billy]

When talking to my son last night. I forgot to mention my server is running http://nginx.org/ Engine X. He says that the environmental variable needs to be changed in the prestashop code to support Engine X. He gave some suggestions / examples of what to look for and what to change it to.

 

<?php
//$_SERVER['REMOTE_ADDR'] = getenv(HTTP_X_FORWARDED_FOR);
echo "\$_SERVER['REMOTE_ADDR'] = " . $_SERVER['REMOTE_ADDR'] . "<br />";
echo "getenv(REMOTE_ADDR) = " . getenv(REMOTE_ADDR) . "<br />";
echo "<br />";
echo "\$_SERVER['HTTP_X_FORWARDED_FOR'] = " . $_SERVER['HTTP_X_FORWARDED_FOR'] . "<br />";
echo "getenv(HTTP_X_FORWARDED_FOR) = " . getenv(HTTP_X_FORWARDED_FOR) . "<br />";
?>

 

What I need to know is if I change the variable in prestashop with one of these above will it affect anything else? Also any ideas on what file / files should be changed?

 

I know this was an important detail to leave out of my bug report. I do apologize to the devs for my over-site on this report.

[Carl Favre]

Hi Billy,

 

Maxence answered you on the forge, can you check with the fix he gave you?

 

http://forge.prestashop.com/browse/PSCFI-3027

[Billy]

Thank you Carl for pointing that out. I haven't visited this issue since Maxence provided the patch. I must be slipping not to come back and thank the Dev for his precious time. Thank You Maxence!

 

Now the reason I have come back to this topic is the same. The new release of prestashop 1.4.5.1 has the same issue as before. What has changed is the code in classes/tools.php so Maxence's patch will no longer work because of the code update of the tools.php

 

I hope it is ok to clone bugs when they are the same issue just different releases. At-least that's what made the most sense to me is to clone. I hope it was the right one. i am learning.

 

http://forge.prestas...2#comment-42902

[Carl Favre]

Hi Billy,

 

 

Yes you can clone it as long as it is for a different version.

 

Maxence has already replied to your bug on the forge .