[SOLVED] How to disallow customers return their products in one order while in shipped status?

[Ali Samie]

While prestashop provides a page for order settings and specially for order status setting, it does no work as expected.
We want our customers to return their products only if it is "Delivered", so I opened order status settings page in back office, and saw that for "Shipped" status we have the "Delivery" flag as active. I disabled this but again when an order is in this status, customer can return products of the order, even they are not arrived and delivered yet!

This is the current order status settings

 

This is the current order details page which you can see customer can return products

[Nickz]

I think you will need someoutside data to accomplish that. The shipping service has that.

[Ali Samie]

2 minutes ago, Nickz said:

I think you will need someoutside data to accomplish that. The shipping service has that.

what do you mean by outside data? like another table? or modification?

I think this should already work with the prestashop order status settings.

in template file of the order return, there is a flag with this key "is-returnable", which means what it says. But when you look anlt the result, it doesn't work properly

[Nickz]

7 minutes ago, Ali Samie said:

what do you mean by outside data? like another table? or modification?

who has the data once the parcel made it? DHL, Fedex etc.???

[Ali Samie]

2 hours ago, Nickz said:

who has the data once the parcel made it? DHL, Fedex etc.???

we do the delivery on our own. we do not use any services

[Nickz]

4 minutes ago, Ali Samie said:

we do the delivery on our own. we do not use any services

Ok than you can manually enter that data.

[bera_ramazan]

please edit

themes/x/templates/custumer/_partials/order-detail-return.tpl

add this code

{if $order.history.current.id_order_state == 5}
XXX
{/if}

add these if columns to the field you want to hide

[Ali Samie]

9 hours ago, bera_ramazan said:

please edit

themes/x/templates/custumer/_partials/order-detail-return.tpl

add this code

{if $order.history.current.id_order_state == 5}
XXX
{/if}

add these if columns to the field you want to hide

Thank you this is a quick fix.

I see that this issue happens here in this file
src/Adapter/Presenter/Order/OrderDetailLazyArray.php

    /**
     * Can this order be returned by the client?
     *
     * @return bool
     */
    public function isReturnable()
    {
        if (Configuration::get('PS_ORDER_RETURN', null, null, $this->id_shop) && $this->isPaidAndShipped()) {
            return $this->getNumberOfDays();
        }

        return false;
    }

I should apply a fix to this method I guess

[Ali Samie]

I fixed it with an override in a custom module
Here is the override

<?php

class Order extends OrderCore
{
    /**
     * Can this order be returned by the client?
     *
     * @return bool
     */
    public function isReturnable()
    {
        return $this->isDelivered()
            && parent::isReturnable();
    }

    /**
     * Checks if the current order status is delivered.
     *
     * @return bool
     */
    public function isDelivered()
    {
        $order_state = $this->getCurrentOrderState();
        if ($order_state->delivery) {
            return true;
        }
        return false;
    }
}