What happened to AJAX functionality in PS 1.7

[theillo]

Question for the Core Devs:

I'm upgrading from 1.6 to 1.7.

Previously I was able to send an Ajax request to the AuthController.

In 1.6 the AuthController had this useful bit of code in it:

       if ($this->ajax) {
            $return = array(
                'hasError' => !empty($this->errors),
                'errors' => $this->errors,
                'token' => Tools::getToken(false)
            );
            $this->ajaxDie(Tools::jsonEncode($return));
        }

This allowed me to make an Ajax request to the Auth Controller, and I'd receive back a Json Object with any errors that might have occurred during login. I could then handle the errors in whichever way I wanted. This worked just fine. Convenient, simple, and effective.

 

However, now there is no trace of this code in the 1.7 Auth Controller. 

 

What's the new process for Ajax calls to front controllers, specifically the Auth Controller?

Edited June 2, 2020 by theillo (see edit history)

[theillo]

Here's the commit during which the removal happened:

https://github.com/PrestaShop/PrestaShop/commit/cd61b3ddc6ca19d5cb90614f1df57b62c1233238

 

538 deletions for AuthController.php and the Ajax functionality was removed. 

Why? Was it put somewhere else?

The title of the commit is "Add account creation in AuthController". Why did we have 538 deletions to "add" something?

[theillo]

I think I found out why it happened:

https://build.prestashop.com/news/prestashop-in-2019-and-beyond-part-2-pain-points/